Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with GMake Makefile conditional assignment operators. #6623

Merged

Conversation

DavidGriffith
Copy link
Contributor

@DavidGriffith DavidGriffith commented Oct 21, 2019

Ordinarily variable assignments in Makefiles are done simply with an unconditional assignment: the equals sign. There are variants of this:

FOO := $(BAR)   Avoid recursively expand variables.
FOO ?= bar      Assign only if $(FOO) is not already set.
FOO += bar      Add more to a variable.
FOO != bar      Execute a shell script and assign result to $(FOO).

See also:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Not sure what new tests would apply or be required for my changes.
Running brew tests showed failures not caused by my changes.

Ordinarily variable assignments in Makefiles are done simply with an
unconditional assignment: the equals sign.  There are variants of this:

FOO := $(BAR)	Avoid recursively expand variables.
FOO ?= bar	Assign only if $(FOO) is not already set.
FOO += bar	Add more to a variable.
FOO != bar	Execute a shell script and assign result to $(FOO).

See also
https://www.gnu.org/software/make/manual/html_node/Conditional-Example.html
https://www.gnu.org/software/make/manual/html_node/Flavors.html
@MikeMcQuaid MikeMcQuaid changed the title Gmake conditional assignment Deal with GMake Makefile conditional assignment operators. Oct 21, 2019
@MikeMcQuaid MikeMcQuaid merged commit 962ca6a into Homebrew:master Oct 21, 2019
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @DavidGriffith!

@DavidGriffith DavidGriffith deleted the gmake-conditional-assignment branch October 21, 2019 09:38
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants